The New York pass isn't very good, but the New York City Pass (yes they are different!) is great!
You actually save a lot of money on admission, you don't have to wait in line to buy tickets, most attractions have express entry for you, you don't have to waste time talking to ticket sellers on the street who want to sell you a heap of useless extras that you just don't need (especially the guys outside the empire state), it gives you entry to all the major attractions, so if it's your first visit, it's all the places you'd probably include anyway.
It doesn't include the option to climb up to the crown of the statue of liberty - if you want this you'll have to book it separately and do it well in advance. As there is a limited number of people allowed up each day, it can book out as much as 6 months in advance. about 6 years ago
I hosted a friend in NY a couple of months ago & he asked me the same question about the New York Pass. Ultimately, we had to go through the full list of attractions, how much they cost, and which ones he was interested in, and found that it was worth getting a multi-day pass. He used the pass to the max and was very happy with all that he got.
As a New Yorker, I don't need/want the pass, but as a tourist, it seems worth it...again, depending on what you're interested in seeing. Don't just wing it...plan it! almost 5 years ago